LÖVE

Ross wrote: ↑Sat May 16, 2020 1:20 am The most basic way to debug things is to and add `print()` statements to your code where you think thing's might be going wrong and run it with a console open. You know that jumping is messed up, so add some prints to your jumping code.

In this case, I added `print("startJump", v)` and `print("endJump", v)` inside your jumping timer functions. If you watch the console, you'll see two "startJump"s, but only one "endJump". You're calling `enemyTimer:clear()`, which I'm kills all timers for all enemies, so the second enemy's jump never ends and it flies into the stratosphere. I don't know why you're calling clear.


Just a note, you're using global variables eeeeeeverywhere. All of your functions and almost half of your regular variables. That's going to give you serious problems sooner or later. You'll happen to use the same name in a different script, and all of a sudden something completely unrelated will be broken and it will be pretty hard to figure out why. For example you have `currentAnimation` as a global variable. Imagine you add a menu with buttons, and each button has a `currentAnimation`. Well, then you'll completely crash your player script even though you didn't touch it.

In general, you should never make any global variables. You only need a global variable for something that every single script in your game may need access too, because that's what exactly what making it global means. Otherwise, use modules. Any script can require and use them, similar to a global variable, but are much easier to keep track of and almost never cause naming collisions.

Some references about modules (or "packages"): http://lua-users.org/wiki/ModulesTutorial, or https://www.lua.org/pil/15.html, or https://www.tutorialspoint.com/lua/lua_modules.htm


There were some other weird things I noticed. In love.update (in main.lua), you're calling playerAnimUpdate (in player.lua). Inside playerAnimUpdate you're calling newCheckAttack and inside that you're defining love.mousepressed and love.mousereleased. Those are generally functions you define once and they never change, you definitely don't need to redefine them every frame.

function enemyJump()
  for k,v in pairs(enemy) do
    enemyTimer:after(3,
    function() v.jumping = true
      print('Startjump', v)
      enemyTimer:clear()
      enemyTimer:after(0.00001,
      function() v.jumping = false
        print('EndJump', v)
        enemyTimer:clear() end)
    end)
  end
end

SlyXPG wrote: ↑Sat May 16, 2020 3:14 am I don't know if this is an issue with how I’m calling the timer function, or if its an issue with HUMP.timer...

Ross wrote: ↑Sat May 16, 2020 1:20 am ...Otherwise, use modules. Any script can require and use them, similar to a global variable, but are much easier to keep track of and almost never cause naming collisions.

Ross wrote: ↑Sat May 16, 2020 3:10 pm Oh, yeah, you're adding a new timer for every enemy every frame. That will definitely cause issues. You just want them to jump every 3 seconds, right? So you just need a repeating, 3-second timer that tells the enemy to jump, and only cancel it when the enemy dies. Hump.timer has Timer.every for that. https://hump.readthedocs.io/en/latest/t ... imer.every
You'll want to start one every time you spawn an enemy, and cancel it when it dies.

You were also calling `moveEnemy(dt)` three times every frame?!

I messed around and reworked your enemy.lua to something like how I would do it (and a few things in main.lua and player.lua to use the changes). No global variables, a self-contained module that other scripts can't break (easily). In several places you were applying things to ALL of the enemies, rather than dealing with them individually. Your beginContact & endContact code for example. Also, you don't need to handle everything on update. That's the point of using timers, all you need to do is timer:update(dt) every update, and everything else just fires once when it needs to. There was no reason to do jumping stuff on update, just apply an impulse once at the moment of the jump.
SlyXPG Platformer Modified.zip

Ross wrote: ↑Sat May 16, 2020 3:14 pm

SlyXPG wrote: ↑Sat May 16, 2020 3:14 am I don't know if this is an issue with how I’m calling the timer function, or if its an issue with HUMP.timer...

Hehe, well, when in doubt, using a popular library like that, it's your own code that is wrong, not someone else's. (this applies to me as well)

Ross wrote: ↑Sun May 17, 2020 12:21 pm Hahaha, no worries! You don't want to see my code from a couple years ago. Cleaning up code is actually quite fun, I'm glad I could help a bit at the same time. Figuring out how to organize stuff is the hardest part. Good luck!