LÖVE

pgimeno wrote: ↑Thu Jul 19, 2018 11:49 pm Hello, welcome to the forums. Without any code to examine, all we can do is guess. My guess here is that you may be altering table contents through references. Consider this:

Code: Select all

$ lua
Lua 5.1.5  Copyright (C) 1994-2012 Lua.org, PUC-Rio
> a = {x=1}
> b = a
> b.x = 2
> print(a.x)
2

Tables are mutable objects that exist in memory. A variable is a reference to the object, and if you assign a variable to another, you're copying the reference, not the object. After the line 'b=a' there's only one table object, but there are two references to it, and if it's altered through one reference, the results become visible through the other reference.

pgimeno wrote: ↑Thu Jul 19, 2018 11:49 pmOr I may be wrong in my guess, in which case it would help if you can attach a .love file that we can examine, to try to find out where the problem can be rather than guessing.

SpeedySloth wrote: ↑Fri Jul 20, 2018 12:04 pm Thanks for your reply! Sorry for taking so long to respond. I've looked through the code and can't see any rogue references, so I don't thing it's that.

animation.properties =
{
    atlas,
    speed,
    framecount,
    framewidth,
    frameheight,
    fields =
    {
        timer = 0,
        framecounter = 0,
    }
}

function animation:new(a, s, fc, fw, fh)
    animation.properties.atlas = a
    animation.properties.speed = s
    animation.properties.framecount = fc
    animation.properties.framewidth = fw
    animation.properties.frameheight = fh

    local self = setmetatable(animation.properties, animation)
    return self
end

function animation.new(a, s, fc, fw, fh)
    local self = setmetatable({}, animation) -- the {} here creates a brand new table on every call
    self.atlas = a
    self.speed = s
    self.framecount = fc
    self.framewidth = fw
    self.frameheight = fh

    return self
end

    gamestate.playerupanim = animation.new(gamestate.playerupanimatlas, 10, 2, 16, 32)

pgimeno wrote: ↑Fri Jul 20, 2018 4:10 pm

SpeedySloth wrote: ↑Fri Jul 20, 2018 12:04 pm Thanks for your reply! Sorry for taking so long to respond. I've looked through the code and can't see any rogue references, so I don't thing it's that.

Thanks for sharing the code. Yes, it's that. Look at this code:

Code: Select all

animation.properties =
{
    atlas,
    speed,
    framecount,
    framewidth,
    frameheight,
    fields =
    {
        timer = 0,
        framecounter = 0,
    }
}

function animation:new(a, s, fc, fw, fh)
    animation.properties.atlas = a
    animation.properties.speed = s
    animation.properties.framecount = fc
    animation.properties.framewidth = fw
    animation.properties.frameheight = fh

    local self = setmetatable(animation.properties, animation)
    return self
end

You're only creating one animation.properties table object, when the file loads. Then, every time animation:new() is called, you're returning the same table object, rather than a new table object. This means that every time you call animation:new(), you're modifying and returning the same table.

It makes little sense for animation.properties to contain the returned instance, because animation is a class, and classes don't have their instances as fields. It also makes little sense to have class functions such as new() to be defined or called using the colon syntax, because the instance parameter (the 'self' parameter) is never used (pretty much by definition of a class function). In this case you're ignoring it and creating a new local variable with the same name. The colon syntax is used to call methods in instances.

So I suggest to remove the assignment of animation.properties and rewrite animation.new as follows:

Code: Select all

function animation.new(a, s, fc, fw, fh)
    local self = setmetatable({}, animation) -- the {} here creates a brand new table on every call
    self.atlas = a
    self.speed = s
    self.framecount = fc
    self.framewidth = fw
    self.frameheight = fh

    return self
end

Then call it without using the colon syntax, e.g.

Code: Select all

    gamestate.playerupanim = animation.new(gamestate.playerupanimatlas, 10, 2, 16, 32)

pgimeno wrote: ↑Fri Jul 20, 2018 5:00 pm Can you be more specific? What do you expect where, and what do you get instead?

pgimeno wrote: ↑Fri Jul 20, 2018 5:12 pm Sorry to insist but this is still not specific enough. For me to see the same problem you see, what line(s) should I change in what file(s)?

In the previous case, based on your problem statement, I did a text search and located a line commented out that looked like the one you posted, and deduced that that was the problematic point. In this case, I have no idea what to look at or what to change.

• I'm editing gamestates.lua, and in the function gamestate.load I'm changing this line:

  Code: Select all

      player.texture = image1
  

  to this:

  Code: Select all

      player.texture = gamestate.playerswingupanimatlas
  

  but it's showing the movement texture instead of the swing texture.