Mars Lander. Any collaborators? Noobs welcome.

[Philbywhizz]

Great idea for a community project. I'm keen to have a crack at some love2d coding with it.

I just created a fork but noticed that a lot of the required libraries are missing. Do we need to source them ourselves or do you think they should be submodules?

Edit: I've submitted a pull request for the missing files

[Gunroar:Cannon()]

I'd like the pixel art to show modules as modules are bought. I expect those to overlay the main sprite so I'm thinking this won't be a problem. Perhaps.

Yep, easy sqeeusy...hopefully.

[togFox]

... a lot of the required libraries are missing.

Sorry - my bad. They should be in the repository but slipped my mind. I accepted your merge on mobile phone. Hope it's okay now. Thanks for that contribution!

I assume you got the code to work. Hope you have some fun and find a way to contribute!

[Philbywhizz]

I assume you got the code to work. Hope you have some fun and find a way to contribute!

Yes I got it working (hence the pull request).

I'm still looking over and studying the code (I'm a love2d newbie) so if I find something I'll add to it.

[togFox]

Since you're a github pro I'll suggest you look at the cards/issues on github. There were two projects in the repository.

Maybe pick something small and easy while you get use to the coding style.

[Philbywhizz]

Since you're a github pro I'll suggest you look at the cards/issues on github. There were two projects in the repository.

I'm hardly a pro, but I know my way around git and github to keep myself out of trouble

Can I suggest that you move the library files into a seperate sub-folder (such as lib) from the main game code? It might make it easier for people to see what is lander code and what are libraries.

For example, after moving anim8.lua into the lib folder we can change the code from

Code: Select all

anim8 = require 'anim8'

to

Code: Select all

anim8 = require 'lib.anim8'

[togFox]

Yep. I'll do that next if that helps collaboration.

Edit: Done. I'm still on mobile. I think it's right now.

Do you think a paragraph or two on coding conventions would help? Is the style/pattern already obvious?

I think I'll put comments at the start of each lander module to explain its purpose and what you can expect in each file.

[Philbywhizz]

Just merged in your changes to my local repo - that is much nicer looking now. Well done.

A coding convention would be a nice thing to have, especially when you want multiple people working on it.

Comments are a good thing - especially when it comes to reasons why things are done a certain way.

[Philbywhizz]

The code is intentionally written for noobs - not a single instance of SELF keyword.

Is there a reason for this? I must have missed something. I find using self allows me to group related data together (not necessarily object oriented)

[togFox]

Noobs don't understand Self, classes, oo and state machines etc. Doesn't mean we can't do that.