video:isPlaying() still true after end of play

Questions about the LÖVE API, installing LÖVE and other support related questions go here.
Forum rules
Before you make a thread asking for help, read this.
crocmiam
Prole
Posts: 5
Joined: Tue Dec 22, 2015 7:54 pm

Re: video:isPlaying() still true after end of play

Post by crocmiam »

I've compiled Löve with your last commit, the issue is still here for me.
crocmiam
Prole
Posts: 5
Joined: Tue Dec 22, 2015 7:54 pm

Re: video:isPlaying() still true after end of play

Post by crocmiam »

My bad:
- it's fixed if there is sound
- the issue is still here if there is no sound (love.graphics.newVideo("video.ogv", false))
User avatar
bartbes
Sex machine
Posts: 4946
Joined: Fri Aug 29, 2008 10:35 am
Location: The Netherlands
Contact:

Re: video:isPlaying() still true after end of play

Post by bartbes »

Whoops, that's my bad, I forgot to hook isPlaying up correctly for video that doesn't synchronise to audio. Now it should be fixed, thanks for testing!
crocmiam
Prole
Posts: 5
Joined: Tue Dec 22, 2015 7:54 pm

Re: video:isPlaying() still true after end of play

Post by crocmiam »

Thanks, it works in both cases now.

@Fenrir: Looping works now :)
User avatar
Fenrir
Party member
Posts: 222
Joined: Wed Nov 27, 2013 9:44 am
Contact:

Re: video:isPlaying() still true after end of play

Post by Fenrir »

crocmiam wrote:Thanks, it works in both cases now.

@Fenrir: Looping works now :)
Yep I confirm it works now, thanks a lot for this quick fix! :)
User avatar
murks
Party member
Posts: 185
Joined: Tue Jun 03, 2014 4:18 pm

Re: video:isPlaying() still true after end of play

Post by murks »

I still have this issue. Is it fixed in a dev version only?

I also recommend to consider the cases where the audio track is longer or shorter than the video track.
I guess the sanest thing to do is to set isPlaying() to false IFF both audio and video have stopped playing.

EDIT: I'm sorry, it seems to have been an error in my code. Video.isPlaying() works in 0.10.0.
User avatar
slime
Solid Snayke
Posts: 3162
Joined: Mon Aug 23, 2010 6:45 am
Location: Nova Scotia, Canada
Contact:

Re: video:isPlaying() still true after end of play

Post by slime »

murks wrote:I still have this issue. Is it fixed in a dev version only?
Yes, a new LÖVE version hasn't been released yet since 0.10.0. You can try out nightly development builds here: https://love2d.org/builds/
Post Reply

Who is online

Users browsing this forum: Google [Bot] and 4 guests