Page 2 of 3

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 12:33 am
by kikito
dude. Hermione. :rofl:

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 12:44 am
by TechnoCat
kikito wrote:dude. Hermione. :rofl:
I actually don't think that is Emma Watson.

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 3:34 am
by tentus
Hawt. Have you considered having additional controls appear at the bottom if the mouse dips below a certain height? I can easily see this being the beginning of a new CDisplay.

After looking at the code... You've got some funky indentation in updateImages where you used spaces instead of tabs. Also, there are several little efficiency things you can do here and there, such as using require rather than ("LOVEshow.lua")(). Do you mind if I make a few little tweaks and posted them? I'm not trying to be an ass, I'm just in the market for an open-source program very much like this one.

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 3:41 am
by TechnoCat
tentus wrote:After looking at the code... You've got some funky indentation in updateImages where you used spaces instead of tabs. Also, there are several little efficiency things you can do here and there, such as using require rather than ("LOVEshow.lua")(). Do you mind if I make a few little tweaks and posted them? I'm not trying to be an ass, I'm just in the market for an open-source program very much like this one.
No, please do. I did this back when LOVE 0.6 was pre-release or something. I took a brief look at my code today and facepalmed. Pretty crude looking it was.

EDIT: Let me move it to bitbucket. I would like to see how forked projects work. https://bitbucket.org/dannyfritz/loveshow

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 4:29 am
by tentus
Wow, I have absolutely no idea how to work that site. Can anyone guide me towards how to upload new code? I've created an account and a fork, but now what?

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 4:31 am
by TechnoCat
Well it uses mercurial. So make sure you have that installed.
I see you already forked it, so most of your work with bitbucket is done.
  • Send your terminal/command prompt to the directory you want to clone to.
  • Clone my repo "hg clone https://bitbucket.org/blahblah". The command is on bitbucket.
  • If you add any new files, use "hg add <filename>". Or even "hg add *" to add everything in the current dir.
  • Then whenever you make a finished change you want to keep, do "hg commit" and type a summary of changes. This pushes to your local repo any changes.
  • Then to push to bitbucket, "hg push". Now I can see the change and optionally merge with the main branch.
EDIT: I found a pretty good how to: http://confluence.atlassian.com/pages/v ... =223221162
Hint: Don't give up. Distributed version control systems like HG are a tiny bit hard to pick up, but you will absolutely fall in love with once you get going.

Protip: When you are about to start a new local project, do a "hg init" in your folder so you can track your local changes. I, and many of my peers, always initialize some sort of repo before starting any class assignment.

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 4:59 am
by BlackBulletIV
Wow, the Mercurial commands you stated have exactly the same name in Git. Does Mercurial handle branching like Git does? (as in it doesn't copy files, it just creates a pointer to a commit)

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 6:55 am
by Robin
BlackBulletIV wrote:Wow, the Mercurial commands you stated have exactly the same name in Git. Does Mercurial handle branching like Git does? (as in it doesn't copy files, it just creates a pointer to a commit)
Hg does one thing very differently than git: it stores change sets instead of snapshots, but I don't think branching copies files, I think only old VCS's like CVS do that, because they have no real support for branching.

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 7:21 am
by BlackBulletIV
Ah ok. SVN copies files right?

Re: LOVEshow a simple image viewer

Posted: Fri Jan 14, 2011 7:47 am
by Robin
BlackBulletIV wrote:Ah ok. SVN copies files right?
AFAIK, SVN is basically a pimped CSV, so I think so.