LOVEshow a simple image viewer
- TechnoCat
- Inner party member
- Posts: 1611
- Joined: Thu Jul 30, 2009 12:31 am
- Location: Milwaukee, WI
- Contact:
Re: LOVEshow a simple image viewer
I actually don't think that is Emma Watson.kikito wrote:dude. Hermione.
- tentus
- Inner party member
- Posts: 1060
- Joined: Sun Oct 31, 2010 7:56 pm
- Location: Appalachia
- Contact:
Re: LOVEshow a simple image viewer
Hawt. Have you considered having additional controls appear at the bottom if the mouse dips below a certain height? I can easily see this being the beginning of a new CDisplay.
After looking at the code... You've got some funky indentation in updateImages where you used spaces instead of tabs. Also, there are several little efficiency things you can do here and there, such as using require rather than ("LOVEshow.lua")(). Do you mind if I make a few little tweaks and posted them? I'm not trying to be an ass, I'm just in the market for an open-source program very much like this one.
After looking at the code... You've got some funky indentation in updateImages where you used spaces instead of tabs. Also, there are several little efficiency things you can do here and there, such as using require rather than ("LOVEshow.lua")(). Do you mind if I make a few little tweaks and posted them? I'm not trying to be an ass, I'm just in the market for an open-source program very much like this one.
Kurosuke needs beta testers
- TechnoCat
- Inner party member
- Posts: 1611
- Joined: Thu Jul 30, 2009 12:31 am
- Location: Milwaukee, WI
- Contact:
Re: LOVEshow a simple image viewer
No, please do. I did this back when LOVE 0.6 was pre-release or something. I took a brief look at my code today and facepalmed. Pretty crude looking it was.tentus wrote:After looking at the code... You've got some funky indentation in updateImages where you used spaces instead of tabs. Also, there are several little efficiency things you can do here and there, such as using require rather than ("LOVEshow.lua")(). Do you mind if I make a few little tweaks and posted them? I'm not trying to be an ass, I'm just in the market for an open-source program very much like this one.
EDIT: Let me move it to bitbucket. I would like to see how forked projects work. https://bitbucket.org/dannyfritz/loveshow
- tentus
- Inner party member
- Posts: 1060
- Joined: Sun Oct 31, 2010 7:56 pm
- Location: Appalachia
- Contact:
Re: LOVEshow a simple image viewer
Wow, I have absolutely no idea how to work that site. Can anyone guide me towards how to upload new code? I've created an account and a fork, but now what?
Kurosuke needs beta testers
- TechnoCat
- Inner party member
- Posts: 1611
- Joined: Thu Jul 30, 2009 12:31 am
- Location: Milwaukee, WI
- Contact:
Re: LOVEshow a simple image viewer
Well it uses mercurial. So make sure you have that installed.
I see you already forked it, so most of your work with bitbucket is done.
Hint: Don't give up. Distributed version control systems like HG are a tiny bit hard to pick up, but you will absolutely fall in love with once you get going.
Protip: When you are about to start a new local project, do a "hg init" in your folder so you can track your local changes. I, and many of my peers, always initialize some sort of repo before starting any class assignment.
I see you already forked it, so most of your work with bitbucket is done.
- Send your terminal/command prompt to the directory you want to clone to.
- Clone my repo "hg clone https://bitbucket.org/blahblah". The command is on bitbucket.
- If you add any new files, use "hg add <filename>". Or even "hg add *" to add everything in the current dir.
- Then whenever you make a finished change you want to keep, do "hg commit" and type a summary of changes. This pushes to your local repo any changes.
- Then to push to bitbucket, "hg push". Now I can see the change and optionally merge with the main branch.
Hint: Don't give up. Distributed version control systems like HG are a tiny bit hard to pick up, but you will absolutely fall in love with once you get going.
Protip: When you are about to start a new local project, do a "hg init" in your folder so you can track your local changes. I, and many of my peers, always initialize some sort of repo before starting any class assignment.
- BlackBulletIV
- Inner party member
- Posts: 1261
- Joined: Wed Dec 29, 2010 8:19 pm
- Location: Queensland, Australia
- Contact:
Re: LOVEshow a simple image viewer
Wow, the Mercurial commands you stated have exactly the same name in Git. Does Mercurial handle branching like Git does? (as in it doesn't copy files, it just creates a pointer to a commit)
- Robin
- The Omniscient
- Posts: 6506
- Joined: Fri Feb 20, 2009 4:29 pm
- Location: The Netherlands
- Contact:
Re: LOVEshow a simple image viewer
Hg does one thing very differently than git: it stores change sets instead of snapshots, but I don't think branching copies files, I think only old VCS's like CVS do that, because they have no real support for branching.BlackBulletIV wrote:Wow, the Mercurial commands you stated have exactly the same name in Git. Does Mercurial handle branching like Git does? (as in it doesn't copy files, it just creates a pointer to a commit)
Help us help you: attach a .love.
- BlackBulletIV
- Inner party member
- Posts: 1261
- Joined: Wed Dec 29, 2010 8:19 pm
- Location: Queensland, Australia
- Contact:
- Robin
- The Omniscient
- Posts: 6506
- Joined: Fri Feb 20, 2009 4:29 pm
- Location: The Netherlands
- Contact:
Re: LOVEshow a simple image viewer
AFAIK, SVN is basically a pimped CSV, so I think so.BlackBulletIV wrote:Ah ok. SVN copies files right?
Help us help you: attach a .love.
Who is online
Users browsing this forum: Bing [Bot] and 2 guests