Code: Select all
player.update()Code: Select all
player.collidingRight = function(map)
for i = 1, map.TILE_SIZE - 1 do
if map.isSolid(player.x + map.TILE_SIZE, player.y + i) then
return true
end
end
return false
endCode: Select all
local function getTileXY(x,y,tileWidth,tileHeight)
return math.ceil(x/tileWidth),math.ceil(y/tileHeight)
end
That looks like a great idea, but what would 'dx' and 'dy' be in that context? Thanks in advance. (I realize deltax and deltay, but how would I go about calculating them, and what do they mean?)Roland_Yonaba wrote:All your pain, sufferings and miseries comes from this single function:
Well, you just need to reduce the number of collisions checks made.Code: Select all
player.update()
Say for instance you are move right. Actually player.update() will call player.collidingRight()
Seems that this is really costful, in terms of operations made.Code: Select all
player.collidingRight = function(map) for i = 1, map.TILE_SIZE - 1 do if map.isSolid(player.x + map.TILE_SIZE, player.y + i) then return true end end return false end
I suggest implementing a routine such as getTileXY. When passing player's x,y current position, it will return the x,y position of the player in the tile map.
Then it all becomes simple. When moving in a direction, you just check if tile getTileXY(player.x+dx,player.y+dy,tileWidth,tileHeight) is solid before authorizing this move.Code: Select all
local function getTileXY(x,y,tileWidth,tileHeight) return math.ceil(x/tileWidth),math.ceil(y/tileHeight) end
deltaX and deltaY, in the context, would the amount by which you would increase/decrease player's x and y coordinates each update cycle.munchor wrote: That looks like a great idea, but what would 'dx' and 'dy' be in that context? Thanks in advance. (I realize deltax and deltay, but how would I go about calculating them, and what do they mean?)
Code: Select all
for i = 0, player.vx - 1 do
if player.collidingRight(player.currentMap) then
player.vx = 0
else
player.x = player.x + 1
player.translated = player.translated + 1
end
end
Damn, that really improved performance. I do have more collision bugs now:Roland_Yonaba wrote:deltaX and deltaY, in the context, would the amount by which you would increase/decrease player's x and y coordinates each update cycle.munchor wrote: That looks like a great idea, but what would 'dx' and 'dy' be in that context? Thanks in advance. (I realize deltax and deltay, but how would I go about calculating them, and what do they mean?)
Actually, from what I can see in your code, if there's no collision in the moving direction along X or Y-axis, you use 1.
Example:
So let deltaX and deltaY be 1.Code: Select all
for i = 0, player.vx - 1 do if player.collidingRight(player.currentMap) then player.vx = 0 else player.x = player.x + 1 player.translated = player.translated + 1 end end
Code: Select all
player.update = function()
player.vy = player.vy + player.y_acc
if player.vx > 0 then
for i = 0, player.vx - 1 do
if currentMap.isSolid(player.getTile(player.x + 16, player.y, 16, 16)) then
player.vx = 0
else
player.x = player.x + 1
player.translated = player.translated + 1
end
end
else
for i = 0, math.abs(player.vx) - 1 do
if currentMap.isSolid(player.getTile(player.x - 1, player.y, 16, 16)) then
player.vx = 0
else
player.x = player.x - 1
player.translated = player.translated - 1
end
end
end
if player.vy > 0 then
for i = 0, player.vy - 1 do
if currentMap.isSolid(player.getTile(player.x, player.y + 16, 16, 16)) then
player.vy = 0
else
player.y = player.y + 1
end
end
else
for i = 0, math.abs(player.vy) - 1 do
if currentMap.isSolid(player.getTile(player.x, player.y - 10, 16, 16)) then
player.vy = 0
else
player.y = player.y - 1
end
end
end
(...)
There you goRoland_Yonaba wrote:Can you provide the full updated *.love, please ?
Thanks.