Simple Tetris Clone for LOVE

[_ex_]

Hi guys,
I ported my clone http://code.google.com/p/simple-tetris-clone/ to LOVE



I just learned Lua so the source code it's just a mess of global objects and functions (Game and Platform)
Any help refactoring it? I'm missing the encapsulation and data hiding support of other programming languages
If you can review in pedantic mode I would love to hear about your observations.
I'm aiming for a simple code base but in the Lua spirit.

UPDATE: Added the awesome music theme Jarno gently composed for me.

Thanks!

[ivan]

Looks pretty cool, good work.
Your code is very clear, seems like you know what you're doing.
Since you're going with an event system for the input you can do away with the large if-then code:

Code: Select all

keys = {}
keys["left"] = Game.Event.MOVE_LEFT
keys["right"] = Game.Event.MOVE_RIGHT
...

function Platform:onKeyDown(key)
  if keys[key] then
    Game:onEventStart ( keys[key] )
  end
end

You can then move the keys table to a seperate config file.

Are you moving to Lua from C/C++?
I think with a bit of OO programming a lot of those if-then statements could be avoided.
Other than that the game and code are pretty good.
I do have a couple of minor gripes:
I think you should be allowed to rotate the pieces counter-clockwise (for example with the down arrow)
Visually the game looks good but there's too much text I think.
The button instructions could be removed altogether, and instead of numeric stats perhaps you could have progress bars like in Tengen Tetris on the NES.

[_ex_]

hey Ivan, thanks for the feedback, much appreciated

I think you should be allowed to rotate the pieces counter-clockwise (for example with the down arrow)
Visually the game looks good but there's too much text I think.
The button instructions could be removed altogether, and instead of numeric stats perhaps you could have progress bars like in Tengen Tetris on the NES.

The game support CCW rotations, but that event is not mapped to any key.
I think this little game is more like a demo, the cool things (sound, music, effects) are left as an exercise to the astute reader
I'm not moving to Lua, but I needed a bit of no trivial code in Lua for learning purposes .

[negester]

I'm missing the encapsulation and data hiding support of other programming languages

You do these in Lua via proxy tables. Private items, read-only items, counting accesses to an item, etc.

It's an advanced topic, and I'm not even going to try explaining it. You're obviously an experienced programmer who presumably likes to dive in at the deep end, so visit http://www.lua.org/pil/13.4.html It's somewhere in the subsections.

[josefnpat]

This is a very nice clone! Mind adding a quick fullscreen, and/or a way to scale the game?

Also, I love the "love" colors

[_ex_]

This is a very nice clone! Mind adding a quick fullscreen, and/or a way to scale the game?
Also, I love the "love" colors

Thanks! I just started using the engine, so I don't know how LOVE supports the full-screen scaling with different resolutions and aspect ratios, Does it support automatic black stripes when the aspect ratio is different?. Need to play more with this.

[Robin]

I don't know how LOVE supports the full-screen scaling with different resolutions and aspect ratios,

Yep.

Does it support automatic black stripes when the aspect ratio is different?

Nope.

[slime]

Does it support automatic black stripes when the aspect ratio is different?

I believe that's up to the video driver, not any game or framework or engine.

[_ex_]

Added the awesome music theme Jarno gently composed for me.

[MarekkPie]

Sweet clone. I like the visual drop shadow as well. One thing I'd suggest it some audio indication that you've made a tetris.