Feel free to make PR It would be easier if we can compare the performance of the current `master` branch and your changespirogronian wrote: ↑Wed Oct 26, 2022 6:16 amNope. AFAIK, there is no change in this matter in both branches for now... I want to be wrong, however.yetneverdone wrote: ↑Wed Oct 26, 2022 2:10 amI think the solution to this was already addressed and PR'ed by megagrump which is now in the `master` and `v1.0.0` branchespirogronian wrote: ↑Mon Oct 24, 2022 2:31 pm
This issue is identified for long time. I've already posted about it and proposed some sollution, but based on event processing. It can be found here.
In fact, it's not a "bug". It's rather inavoidable result of chosen approavh, based on state only, without processing direct input events.
Slab - An Immediate Mode GUI Library In Lua
- yetneverdone
- Party member
- Posts: 448
- Joined: Sat Sep 24, 2016 11:20 am
- Contact:
Re: Slab - An Immediate Mode GUI Library In Lua
My GameDev Website
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
-
- Prole
- Posts: 17
- Joined: Sun Jun 30, 2019 5:38 pm
Re: Slab - An Immediate Mode GUI Library In Lua
It's not matter of performance but responsiveness and reliability. And it would mean deep architectural cganfes, as Slab by its design rely on updated state, and events needs some kind of callbacks or message queue. It's something completely different from immediate mode GUI Slab is. So, it would be hard...yetneverdone wrote: ↑Wed Oct 26, 2022 7:05 amFeel free to make PR It would be easier if we can compare the performance of the current `master` branch and your changespirogronian wrote: ↑Wed Oct 26, 2022 6:16 amNope. AFAIK, there is no change in this matter in both branches for now... I want to be wrong, however.yetneverdone wrote: ↑Wed Oct 26, 2022 2:10 am
I think the solution to this was already addressed and PR'ed by megagrump which is now in the `master` and `v1.0.0` branches
- yetneverdone
- Party member
- Posts: 448
- Joined: Sat Sep 24, 2016 11:20 am
- Contact:
Re: Slab - An Immediate Mode GUI Library In Lua
Well, we can also compare responsiveness. I just want to make sure it will not take too much garbage
My GameDev Website
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
-
- Prole
- Posts: 17
- Joined: Sun Jun 30, 2019 5:38 pm
Re: Slab - An Immediate Mode GUI Library In Lua
Oj, I found the commit that addresses it, but dont understand, how it works without forwarding events from Love... @Grump, could you explain it?yetneverdone wrote: ↑Wed Oct 26, 2022 2:10 amI think the solution to this was already addressed and PR'ed by megagrump which is now in the `master` and `v1.0.0` branchespirogronian wrote: ↑Mon Oct 24, 2022 2:31 pmThis issue is identified for long time. I've already posted about it and proposed some sollution, but based on event processing. It can be found here.yetneverdone wrote: ↑Sun Dec 19, 2021 11:21 pm
Oh so this is indeed a bug. I also notice this on my quite large game but didnt realize it til now.
In fact, it's not a "bug". It's rather inavoidable result of chosen approavh, based on state only, without processing direct input events.
- yetneverdone
- Party member
- Posts: 448
- Joined: Sat Sep 24, 2016 11:20 am
- Contact:
Re: Slab - An Immediate Mode GUI Library In Lua
Here are related info in the repo from megagrumppirogronian wrote: ↑Fri Oct 28, 2022 7:43 amOj, I found the commit that addresses it, but dont understand, how it works without forwarding events from Love... @Grump, could you explain it?yetneverdone wrote: ↑Wed Oct 26, 2022 2:10 amI think the solution to this was already addressed and PR'ed by megagrump which is now in the `master` and `v1.0.0` branchespirogronian wrote: ↑Mon Oct 24, 2022 2:31 pm
This issue is identified for long time. I've already posted about it and proposed some sollution, but based on event processing. It can be found here.
In fact, it's not a "bug". It's rather inavoidable result of chosen approavh, based on state only, without processing direct input events.
https://github.com/flamendless/Slab/pull/107
https://github.com/flamendless/Slab/issues/102
My GameDev Website
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
Re: Slab - An Immediate Mode GUI Library In Lua
From the code patch, it appears that events were dropped because the table was iterated in forwards order, not in backwards order. It also appears that the events were treated as a stack, not a queue.
-
- Prole
- Posts: 17
- Joined: Sun Jun 30, 2019 5:38 pm
Re: Slab - An Immediate Mode GUI Library In Lua
I have finally found the code and way Slab handles events. It's by overriding handlers directly. To me, it's very bad idea, as I may wish to handle events as well. But Slab takes everything for itself. I strongly recommend to enable forwarding funtions instead of overriding handlers.yetneverdone wrote: ↑Fri Oct 28, 2022 3:43 pmHere are related info in the repo from megagrumppirogronian wrote: ↑Fri Oct 28, 2022 7:43 amOj, I found the commit that addresses it, but dont understand, how it works without forwarding events from Love... @Grump, could you explain it?yetneverdone wrote: ↑Wed Oct 26, 2022 2:10 am
I think the solution to this was already addressed and PR'ed by megagrump which is now in the `master` and `v1.0.0` branches
https://github.com/flamendless/Slab/pull/107
https://github.com/flamendless/Slab/issues/102
- yetneverdone
- Party member
- Posts: 448
- Joined: Sat Sep 24, 2016 11:20 am
- Contact:
Re: Slab - An Immediate Mode GUI Library In Lua
PRs are welcome for the proposed changespirogronian wrote: ↑Sat Oct 29, 2022 9:33 amI have finally found the code and way Slab handles events. It's by overriding handlers directly. To me, it's very bad idea, as I may wish to handle events as well. But Slab takes everything for itself. I strongly recommend to enable forwarding funtions instead of overriding handlers.yetneverdone wrote: ↑Fri Oct 28, 2022 3:43 pmHere are related info in the repo from megagrumppirogronian wrote: ↑Fri Oct 28, 2022 7:43 am
Oj, I found the commit that addresses it, but dont understand, how it works without forwarding events from Love... @Grump, could you explain it?
https://github.com/flamendless/Slab/pull/107
https://github.com/flamendless/Slab/issues/102
My GameDev Website
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
Going Home:A Pixelated Horror Game
My Repositories!
Follow me lovingly!
Nga pala, pinoy ako.
-
- Prole
- Posts: 17
- Joined: Sun Jun 30, 2019 5:38 pm
Re: Slab - An Immediate Mode GUI Library In Lua
Ok, my another realisation: Slab actually calls all previously defined handlers by itself. It works with statically defined callbacks, but I'm unsure about other side effects of such a behaviour. Maybe it should be mentioned in documentation to avoid accidental and surprising misbehaviour if user will manipulate with callbacks more dynamically.yetneverdone wrote: ↑Sat Oct 29, 2022 11:26 amPRs are welcome for the proposed changespirogronian wrote: ↑Sat Oct 29, 2022 9:33 am I have finally found the code and way Slab handles events. It's by overriding handlers directly. To me, it's very bad idea, as I may wish to handle events as well. But Slab takes everything for itself. I strongly recommend to enable forwarding funtions instead of overriding handlers.
Who is online
Users browsing this forum: Bing [Bot] and 3 guests