I see, the issue has to be around here.
https://github.com/matiasah/shadows/blo ... s.lua#L104
Though I'm not completely sure what could be causing it. Maybe the distance between the farthest pixel to the center of the light, is lower than the radius value that the shader is using. So when doing the division: Distance / Radius it never reaches 1.0
Edit:
Either way, the distance is quite big and it goes beyond 1.0, when doing the 1.0 - Distance / Radius subtraction it treats the negative output as a positive number (I don't think this could be the case because it makes no sense that a negative number is treated as a positive).
Edit 2:
How does it look if you comment this line?
https://github.com/matiasah/shadows/blo ... t.lua#L255
Shädows (A light engine)
-
- Citizen
- Posts: 73
- Joined: Thu May 25, 2017 1:43 pm
Re: Shädows (A light engine)
Its becomes much more visible and brighter.
Re: Shädows (A light engine)
Yeah, but this time we've realized that it's indeed the light shader the one that is not working, it isn't doing the fade effect at all. I'm going to have to check this out on GLES soon.
Edit:
My guess is that in
https://github.com/matiasah/shadows/blo ... s.lua#L102
Distance is always way lower than Radius, I don't know why this happens.
Edit:
My guess is that in
https://github.com/matiasah/shadows/blo ... s.lua#L102
Distance is always way lower than Radius, I don't know why this happens.
Re: Shädows (A light engine)
I solved your issue and commited it to the git, it was a compatibility issue which I posted here.
https://bitbucket.org/rude/love/issues/ ... difference
https://bitbucket.org/rude/love/issues/ ... difference
-
- Citizen
- Posts: 73
- Joined: Thu May 25, 2017 1:43 pm
Re: Shädows (A light engine)
Its still there but not that visible though.
Re: Shädows (A light engine)
Hello everyone. Does anyone have the same problem? FPS drops when a moving object (body is updated in love.update). I want the shadow to be cast from dynamic objects (NPC, boxes, etc.).
https://www.youtube.com/watch?v=HcuPDtpkEUU
P.s corrected link
https://www.youtube.com/watch?v=HcuPDtpkEUU
P.s corrected link
Last edited by DeNick on Fri Nov 16, 2018 3:07 pm, edited 1 time in total.
-
- Citizen
- Posts: 65
- Joined: Wed Mar 07, 2018 11:21 pm
Re: Shädows (A light engine)
https://github.com/matiasah/shadows/issues/29DeNick wrote: ↑Wed Nov 14, 2018 2:21 pm Hello everyone. Does anyone have the same problem? FPS drops when a moving object (body is updated in love.update). I want the shadow to be cast from dynamic objects (NPC, boxes, etc.).
https://www.youtube.com/watch?v=HcuPDtpkEU
Re: Shädows (A light engine)
It's not quite what I need. Updated the link to the video.MissDanish wrote: ↑Fri Nov 16, 2018 1:09 amhttps://github.com/matiasah/shadows/issues/29DeNick wrote: ↑Wed Nov 14, 2018 2:21 pm Hello everyone. Does anyone have the same problem? FPS drops when a moving object (body is updated in love.update). I want the shadow to be cast from dynamic objects (NPC, boxes, etc.).
https://www.youtube.com/watch?v=HcuPDtpkEU
https://www.youtube.com/watch?v=HcuPDtpkEUU
- zorg
- Party member
- Posts: 3465
- Joined: Thu Dec 13, 2012 2:55 pm
- Location: Absurdistan, Hungary
- Contact:
Re: Shädows (A light engine)
You are limiting what gets actually rendered, right? and you're not rendering things outside of the visible viewport, right? Because that can eat tons of extra processing that could be avoided.DeNick wrote: ↑Fri Nov 16, 2018 3:19 pm It's not quite what I need. Updated the link to the video.
https://www.youtube.com/watch?v=HcuPDtpkEUU
Me and my stuff True Neutral Aspirant. Why, yes, i do indeed enjoy sarcastically correcting others when they make the most blatant of spelling mistakes. No bullying or trolling the innocent tho.
-
- Citizen
- Posts: 65
- Joined: Wed Mar 07, 2018 11:21 pm
Re: Shädows (A light engine)
If you are referring to the actual lights that shouldn't be an issue since I actually helped make sure nothing unnecessary is rendered when the lights are not in range. It even destroys the canvases when it's out of range (the part I helped with).zorg wrote: ↑Fri Nov 16, 2018 6:08 pmYou are limiting what gets actually rendered, right? and you're not rendering things outside of the visible viewport, right? Because that can eat tons of extra processing that could be avoided.DeNick wrote: ↑Fri Nov 16, 2018 3:19 pm It's not quite what I need. Updated the link to the video.
https://www.youtube.com/watch?v=HcuPDtpkEUU
Who is online
Users browsing this forum: Google [Bot] and 4 guests