push - a resolution-handling library

[slime]

It would probably be beneficial to use [wiki]love.window.setFullscreen[/wiki] rather than [wiki]love.window.setMode[/wiki] when switching between fullscreen and windowed mode. The former function doesn't need to reload OpenGL objects or recreate the window, so it's more efficient and it leaves Canvases and shader extern/uniforms intact.

[Ulydev]

It would probably be beneficial to use [wiki]love.window.setFullscreen[/wiki] rather than [wiki]love.window.setMode[/wiki] when switching between fullscreen and windowed mode. The former function doesn't need to reload OpenGL objects or recreate the window, so it's more efficient and it leaves Canvases and shader extern/uniforms intact.

Wow, I didn't know that was faster! Thanks slime

EDIT: I just tried it and it seems like it's keeping resolution too. It looks very blurry if I have a small window resolution...

[slime]

For exclusive-fullscreen it uses the closest fullscreen mode to the windowed-mode resolution, yeah. Fullscreen-desktop mode always uses the resolution of the desktop, however.

[Ulydev]

For exclusive-fullscreen it uses the closest fullscreen mode to the windowed-mode resolution, yeah. Fullscreen-desktop mode always uses the resolution of the desktop, however.

Thanks! It now works as expected.

[padicao2010]

Great!

Two suggestions:
1 Add LICENSE
2 Not change love.resize so roughly

[zorg]

Not change love.resize so roughly

From looking at the code, i did not see it even using love.resize anywhere, and even if it would, it would only do a few calculations with push:resize... so i don't see the problem.

I do agree with adding a license though.

[padicao2010]

From looking at the code, i did not see it even using love.resize anywhere, and even if it would, it would only do a few calculations with push:resize... so i don't see the problem.

Here, line 106

Code: Select all

function love.resize(w, h) return push:resize(w, h) end

Actually, it's not a big problem. I just commented it and write my resize with push:resize in my codes, for I have some other codes in love.resize.

[zorg]

I stand corrected, you are right
Ulydev: Redefining love.resize in the code is not really a good idea, why not let the user just put the push:resize callback themselves into love.resize on their own?

[Ulydev]

Done!

Added a license and removed the love.resize definition. You'll now have to call push:resize(w, h) yourself.

Thank you guys for the suggestions!

[soulaymenc]

awesome projet, really nice to see a lot of people making awesome libs for löve keep up, i'll use it one day and i will tell you