[library] shine - post processing effects for everyone

Showcase your libraries, tools and other projects that help your fellow love users.
User avatar
zorg
Party member
Posts: 3468
Joined: Thu Dec 13, 2012 2:55 pm
Location: Absurdistan, Hungary
Contact:

Re: [library] shine - post processing effects for everyone

Post by zorg »

Works for me now, on nvidia.

Although, if i move the gaussian blur shader's slider all the way to the left, it errors with "line 4: undefined variable "nanf"
Probably a div by 0 issue :3
Me and my stuff :3True Neutral Aspirant. Why, yes, i do indeed enjoy sarcastically correcting others when they make the most blatant of spelling mistakes. No bullying or trolling the innocent tho.
davisdude
Party member
Posts: 1154
Joined: Sun Apr 28, 2013 3:29 am
Location: North Carolina

Re: [library] shine - post processing effects for everyone

Post by davisdude »

Nice work!
On the Gaussian blur effect if you move the slider all the way to the left you get the error:
Error

Cannot compile pixel shader code:
Line 2: WARNING: Only GLSL version > 110 allows prefix "F" or "f" for float
Line 3: ERROR: 'nanf' : undeclared identifier
Line 3: WARNING: Only GLSL version > 110 allows prefix "F" or "f" for float
I feel like somebody's already let you know about this error, but oh well.
GitHub | MLib - Math and shape intersections library | Walt - Animation library | Brady - Camera library with parallax scrolling | Vim-love-docs - Help files and syntax coloring for Vim
User avatar
Robin
The Omniscient
Posts: 6506
Joined: Fri Feb 20, 2009 4:29 pm
Location: The Netherlands
Contact:

Re: [library] shine - post processing effects for everyone

Post by Robin »

I'd really like a bloom shader, I've never gotten it to work myself.
Help us help you: attach a .love.
User avatar
vrld
Party member
Posts: 917
Joined: Sun Apr 04, 2010 9:14 pm
Location: Germany
Contact:

Re: [library] shine - post processing effects for everyone

Post by vrld »

Incidentally, I just added a simple bloom effect. I am sure that could be done better (slime...?), but it seems to work.
The updated demo contains a second image where the effect is more visible.

Positive07 also did some efforts to get the shaders to run on android.
After fixing some stuff I got the to run on my phone as well.
There is now also an option to change the grain size in the filmgrain effect.

Any other suggestions/ideas for effects?
I'll try to complete the wiki with information how to write your own effects and how to get them into the repo tomorrow evening.
I have come here to chew bubblegum and kick ass... and I'm all out of bubblegum.

hump | HC | SUIT | moonshine
User avatar
kikito
Inner party member
Posts: 3153
Joined: Sat Oct 03, 2009 5:22 pm
Location: Madrid, Spain
Contact:

Re: [library] shine - post processing effects for everyone

Post by kikito »

Hi there,

Congrats on the idea, this looks like a very good initiative.

The demo fails for me in several occasions (I just re-downloaded it again to make sure).
  • When selecting colorgradesimple, I get "quickie/slider.lua:35: Invalid argument. (from main.lua:156)
  • Gaussianblur throws an error if the slider is set to 0: Line 4: ERROR: Use of undeclared identifier 'nan' (from shine/gaussianblur.lua:91: in function 'set')
  • A similar error happens when sigma is set to 0 in simpleglow: Line 4: ERROR: Use of undeclared identifier 'nan' (from shine/simpleglow.lua:104: in function 'set')
vrld wrote:Any other suggestions/ideas for effects?
Too many. :crazy:
When I write def I mean function.
User avatar
vrld
Party member
Posts: 917
Joined: Sun Apr 04, 2010 9:14 pm
Location: Germany
Contact:

Re: [library] shine - post processing effects for everyone

Post by vrld »

kikito wrote:The demo fails for me in several occasions (I just re-downloaded it again to make sure).
Whoops... should be fixed now.
uhm..
I have come here to chew bubblegum and kick ass... and I'm all out of bubblegum.

hump | HC | SUIT | moonshine
User avatar
undef
Party member
Posts: 438
Joined: Mon Jun 10, 2013 3:09 pm
Location: Berlin
Contact:

Re: [library] shine - post processing effects for everyone

Post by undef »

vrld wrote: Any other suggestions/ideas for effects?
I'd love to see a dilate and an erode shader :)

Really like the effects in this video:

twitter | steam | indieDB

Check out quadrant on Steam!
User avatar
zorg
Party member
Posts: 3468
Joined: Thu Dec 13, 2012 2:55 pm
Location: Absurdistan, Hungary
Contact:

Re: [library] shine - post processing effects for everyone

Post by zorg »

A new error! Again when setting gaussian blur's variable to 0.
shine/gaussianblur.lua:75: Variable 'direction' does not exist.
A common error is to define but not use the variable.

Also same error with glowsimple, on glowsimple.lua:87
Me and my stuff :3True Neutral Aspirant. Why, yes, i do indeed enjoy sarcastically correcting others when they make the most blatant of spelling mistakes. No bullying or trolling the innocent tho.
User avatar
Foxcraft
Prole
Posts: 49
Joined: Sat Mar 22, 2014 8:56 pm

Re: [library] shine - post processing effects for everyone

Post by Foxcraft »

Awesome work, vrid! :awesome: Very cool.
User avatar
dizzykiwi3
Citizen
Posts: 58
Joined: Tue Jan 14, 2014 2:03 am

Re: [library] shine - post processing effects for everyone

Post by dizzykiwi3 »

This is AMAZING.
Do you know if it works with cameras and scissors? I seem to be having troubles with it, and I'm not sure if its because of my misuse of it or incompatibility with those.
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest