My first project with LOVE2D!

Showcase your libraries, tools and other projects that help your fellow love users.
Bicentric
Prole
Posts: 28
Joined: Fri Jul 12, 2013 12:17 pm

My first project with LOVE2D!

Post by Bicentric »

-
Last edited by Bicentric on Tue Jun 19, 2018 7:28 pm, edited 2 times in total.
Gravy
Citizen
Posts: 80
Joined: Sun Jan 22, 2012 10:15 pm
Location: CA, USA

Re: My first project with LOVE2D!

Post by Gravy »

Good start. You should highlight the correct answer and pause for a second before moving onto the next. You could also implement some kind of scoring system.
jjmafiae
Party member
Posts: 1331
Joined: Tue Jul 24, 2012 8:22 am

Re: My first project with LOVE2D!

Post by jjmafiae »

Bicentric wrote:mainly doing little projects that eventually get put in the recycle bin...
that's stupid, you should keep all artifacts from the past, its like destroying all old buildings on earth!
User avatar
AnRu
Citizen
Posts: 69
Joined: Sun Oct 27, 2013 1:33 pm
Contact:

Re: My first project with LOVE2D!

Post by AnRu »

For first project it's very pretty. Good luck!
Germanunkol
Party member
Posts: 712
Joined: Fri Jun 22, 2012 4:54 pm
Contact:

Re: My first project with LOVE2D!

Post by Germanunkol »

Since you asked for opinions on your coding-style: It's very neat! Much neater than most of my code tends to be. Of course, when you start splitting the code into multiple files and classes, it will get a little more complicated, but looking at your code right now, I'm sure you'll get that right as well.

Two things I noticed:
a) you should make _everything_ local which doesn't absolutely have to be global. Of course, here, it doesn't matter much since you're only using one file and the project is still small - but later on, you should really look out for that, so it's good practice to start making everything local (inside and outside of functions) even now.
b) Some of your lines are very long (see line 118 for example). This results in ugly line breaks. Lua is very forgiving with line breaks, you can try something like

Code: Select all

if (mx > b1px and my > b1py) and (mx < (b1px + image_buttonHiraganaNormal:getWidth()) and
    my < (b1py + image_buttonHiraganaNormal:getHeight())) then
instead. That's nicer for many editors and monitors (including pastebin, as you can see)


Another, not code-related point: The title screen isn't that great in my opinion. Some words are hardly readable and the red buttons don't really fit into the background nor with the overall colour.

Other than that, very good start, and welcome to the forums and Love!


@jjmafae, he said _recycle_ bin... that means he might re-use the code, which is nice ;)
trAInsported - Write AI to control your trains
Bandana (Dev blog) - Platformer featuring an awesome little ninja by Micha and me
GridCars - Our jam entry for LD31
Germanunkol.de
jjmafiae
Party member
Posts: 1331
Joined: Tue Jul 24, 2012 8:22 am

Re: My first project with LOVE2D!

Post by jjmafiae »

no recycle bin is the place that delete files and stuff
Bicentric
Prole
Posts: 28
Joined: Fri Jul 12, 2013 12:17 pm

Re: My first project with LOVE2D!

Post by Bicentric »

-
Last edited by Bicentric on Tue Jun 19, 2018 7:28 pm, edited 1 time in total.
User avatar
ejmr
Party member
Posts: 302
Joined: Fri Jun 01, 2012 7:45 am
Location: South Carolina, U.S.A.
Contact:

Re: My first project with LOVE2D!

Post by ejmr »

Looks pretty good. I also think you should add some type of score or indication of an incorrect answer, or both. I also think you should add all of the characters with 濁点 like ざ、が、ば、the ones with 半濁点 like ぱ and ぷ, and the 拗音 like きょ、ちゅ、にゃ、and so on.
ejmr :: Programming and Game-Dev Blog, GitHub
南無妙法蓮華經
Bicentric
Prole
Posts: 28
Joined: Fri Jul 12, 2013 12:17 pm

Re: My first project with LOVE2D!

Post by Bicentric »

-
Last edited by Bicentric on Tue Jun 19, 2018 7:27 pm, edited 1 time in total.
mikeisinlove
Prole
Posts: 44
Joined: Sun Mar 31, 2013 11:55 am

Re: My first project with LOVE2D!

Post by mikeisinlove »

Bicentric wrote:
ejmr wrote:Looks pretty good. I also think you should add some type of score or indication of an incorrect answer, or both. I also think you should add all of the characters with 濁点 like ざ、が、ば、the ones with 半濁点 like ぱ and ぷ, and the 拗音 like きょ、ちゅ、にゃ、and so on.
Ah yes that would be a good idea, that's a definite thing that I will be adding, since I struggle with the dakuten a lot.

あなたは日本語が話しますか?
僕は日本語少し分かり!六月から勉強しています。
来月に日本語能力試験N4テストを致します。
僕の語彙が良いだ、でも僕の文法はへただ。僕は二千言葉大体知っている。
あなたは? 
Post Reply

Who is online

Users browsing this forum: No registered users and 1 guest